Add verbose option to the node server. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is somewhat handy when checking if network requests happen during the benchmark run itself. I clear the screen then click start and if any resources are fetched logging will be printed to the terminal session. It doesn't catch network requests but those are more obvious during development. For posterity, after a bit of debugging I realized that you have to pass options as `npm run server -- --verbose` rather than `npm run server --verbose`
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I would not be opposed to enable this by default and have a |
Contributor
|
Looks like a default value for port is missing? |
camillobruni
approved these changes
Jan 6, 2026
Contributor
Author
Weird, I don't see that, nor did I change it AFAIK... How are you running the server? |
Contributor
|
This was from the CI: https://github.com/WebKit/JetStream/actions/runs/20381233883/job/58571960463?pr=249 |
Contributor
Author
Oh I see, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat handy when checking if network requests happen during the benchmark run itself. I clear the screen then click start and if any resources are fetched logging will be printed to the terminal session. It doesn't catch network requests but those are more obvious during development.
For posterity, after a bit of debugging I realized that you have to pass options as
npm run server -- --verboserather thannpm run server --verbose