Remove references to update_revision and fix generate_live_config()#218
Open
matthijskooijman wants to merge 2 commits intoWebconverger:masterfrom
Open
Remove references to update_revision and fix generate_live_config()#218matthijskooijman wants to merge 2 commits intoWebconverger:masterfrom
matthijskooijman wants to merge 2 commits intoWebconverger:masterfrom
Conversation
This variable / option was no longer used, but it was stil defined and there were still some comments talking about it.
This function isn't used with regular Webconverger images, but allows upgrading of live hdd images without installing. Since the 486 kernel is no longer available, no bootloader menu option should be generated for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just two small things I encountered. Changes are untested, but the first one is just comments and an unused variable, the second commit is in code that isn't normally used in Webconverger.