Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Modernizes the project’s tooling and TypeScript compatibility by upgrading key dependencies (Mocha/Sinon/TypeScript/Log4js), switching coverage tooling to nyc, and applying the necessary source/test updates to compile and run under the newer toolchain.
Changes:
- Upgraded runtime/dev dependencies (notably
log4js,mocha,sinon,typescript) and updated the lockfile to npm lockfile v3. - Replaced Istanbul/remap-istanbul coverage scripts with
nycand addednycconfiguration inpackage.json. - Updated tests for Sinon sandbox API changes and TypeScript 4 strictness; adjusted abstract method declarations to remove unsupported
abstract asynccombinations.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/route.test.ts | Updates Sinon sandbox creation for newer Sinon versions. |
| src/test/processors/throttler/memory-queue.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/throttler/memory-pub-sub.test.ts | Updates Sinon sandbox creation and Promise resolve typing. |
| src/test/processors/throttler.test.ts | Updates Sinon sandbox creation and Promise typing for TS4. |
| src/test/processors/resource-throttler.test.ts | Updates Sinon sandbox creation and Promise typing for TS4. |
| src/test/processors/processor.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/mapper.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/logger.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/filter.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/dispatcher.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/timer.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/store.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/memory-timer.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/memory-store.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/max-num-strategy.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator/aggregation-strategy.test.ts | Updates Sinon sandbox creation. |
| src/test/processors/aggregator.test.ts | Updates Sinon sandbox creation. |
| src/lib/processors/throttler/queue.ts | Removes abstract async from method declarations for TS4 compatibility. |
| src/lib/processors/throttler/pub-sub.ts | Removes abstract async from method declarations for TS4 compatibility. |
| src/lib/processors/processor.ts | Removes abstract async from method declarations for TS4 compatibility. |
| src/lib/processors/aggregator/store.ts | Removes abstract async from method declarations for TS4 compatibility. |
| src/lib/processors/aggregator/aggregation-strategy.ts | Removes abstract async from method declarations for TS4 compatibility. |
| package.json | Updates deps/scripts and adds nyc configuration. |
| package-lock.json | Updates dependency graph and lockfile version to v3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.json — updated dependencies, scripts, and added nyc config:
17 test files — sinon.sandbox.create() → sinon.createSandbox()
5 source files — removed async from abstract method declarations (TS4 no longer allows this combination):
3 test files — fixed new Promise(r => r()) → new Promise(r => r()) for TS4 strictness