fix(internal): fix error code for revert in eth_simulateV1 #33007

[gzliudan]

Proposed changes

Ref: ethereum#33007

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes the per-call error code returned for EVM reverts in eth_simulateV1 results so it matches the canonical revert error code used elsewhere in the codebase (and by clients when decoding revert data).

Changes:

• Use revertErr.ErrorCode() for revert failures in eth_simulateV1 call results (instead of a custom constant).
• Remove the unused errCodeReverted constant from internal/ethapi/errors.go.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/ethapi/simulate.go	Switch revert call error code to revertError.ErrorCode() to return the correct revert code in simulate results.
internal/ethapi/errors.go	Remove errCodeReverted constant after it’s no longer used.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The revert path now returns Code: revertErr.ErrorCode() (3). There isn’t currently a regression test covering the eth_simulateV1 response’s per-call error code for reverts, so this behavior could easily drift again. Consider adding a unit/integration test that executes a simulated call which reverts and asserts calls[i].error.code == 3 (and that error.data matches the revert hex payload).