fix(metrics): add missing GaugeInfo case in GetAll() #33748

[gzliudan]

Proposed changes

GetAll did not return GaugeInfo metrics, which affects "chain/info" and "geth/info".

Ref: ethereum#33748

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes missing GaugeInfo handling in StandardRegistry.GetAll(), ensuring GaugeInfo-based metrics (e.g., chain/info, xdc/info) appear in the registry’s JSON output.

Changes:

• Add a case *GaugeInfo branch in StandardRegistry.GetAll() to include GaugeInfo values in the returned metrics map.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

GetAll() now includes GaugeInfo, but there’s no unit test asserting that GaugeInfo metrics are present/encoded correctly in the JSON registry output (StandardRegistry.MarshalJSON / WriteJSONOnce). Consider extending metrics/json_test.go (or adding a new test) to register a GaugeInfo, Update it with a sample GaugeInfoValue, and assert the resulting JSON includes the expected object under "value".

[Copilot]

Returning GaugeInfoSnapshot.Value() here exposes a map (GaugeInfoValue) that originates from GaugeInfo.value. Since GaugeInfo.Snapshot() currently doesn’t lock/copy the underlying map, JSON marshaling of GetAll() can race with GaugeInfo.Update() and potentially panic with concurrent map iteration/write, and callers could also mutate the returned map. Consider ensuring GaugeInfo.Snapshot() (or this GetAll case) takes the mutex and returns a deep-copied map before storing it in the result.

Suggested change

	values["value"] = metric.Snapshot().Value()
	// Avoid exposing the underlying GaugeInfo map directly.
	// Take the snapshot value and deep-copy it into a new map
	// before storing it in the result.
	if snapshotVal := metric.Snapshot().Value(); snapshotVal != nil {
	copied := make(map[string]interface{}, len(snapshotVal))
	for k, v := range snapshotVal {
	copied[k] = v
	}
	values["value"] = copied
	} else {
	values["value"] = nil
	}