fix(eth): add index to callTracer log #33629

[gzliudan]

Proposed changes

Ref: ethereum#33629

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR aligns the native callTracer log output with receipt log semantics by adding an index field to traced logs, and updates the internal tracer test fixtures accordingly.

Changes:

• Add index to callTracer’s callLog JSON output and populate it from types.Log.Index.
• Update tracer test harness structs to include the new index field.
• Update call_tracer_withLog JSON fixtures (and one internal string expectation) to include index.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
eth/tracers/native/call.go	Adds callLog.Index and populates it for EVM logs in OnLog.
eth/tracers/internal/tracetest/calltrace_test.go	Updates callLog test struct and expected internal JSON to include index.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/simple.json	Adds index field to expected log output.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/notopic.json	Adds index field to expected log output.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/multilogs.json	Adds index field to expected log output for many logs.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/multi_contracts.json	Adds index field to expected log output across multiple contracts/calls.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/delegatecall.json	Adds index field to expected log output for delegatecall traces.
eth/tracers/internal/tracetest/testdata/call_tracer_withLog/calldata.json	Adds index field to expected log output for calldata-related trace.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

callLog now includes an index field, but in OnLog it’s only populated for regular EVM transactions. For non-EVM transactions (t.isNonEVMTx branch earlier in this method), Index is left at the zero value, even though StateDB.AddLog assigns log.Index before invoking the hook. This will cause all non-EVM logs to be emitted with index: "0x0" regardless of their actual order. Populate Index for the non-EVM branch too (e.g., from log.Index, or synthesize from len(t.nonEVMCall.Logs) if needed).