Replace fmt.Print TODO with error return in SNMP enactment driver#98
Open
jjpinto wants to merge 1 commit intoaalyria:mainfrom
Open
Replace fmt.Print TODO with error return in SNMP enactment driver#98jjpinto wants to merge 1 commit intoaalyria:mainfrom
jjpinto wants to merge 1 commit intoaalyria:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small cleanup in getNodeOpts. The SNMP enactment driver case was using a raw fmt.Print, which didn’t quite fit with how the rest of the function handles missing or unimplemented options.
I switched it to return a proper error instead.
The idea here is just to make the behavior a bit clearer and more consistent since the previous version printed a TODO message but didn’t actually signal anything to the caller, so the function would silently fall through.
Returning an error feels more idiomatic and makes it obvious that this path isn’t implemented yet.