Remove execution engine and refactor to transpile-only API#49
Open
conradbzura wants to merge 1 commit intomainfrom
Open
Remove execution engine and refactor to transpile-only API#49conradbzura wants to merge 1 commit intomainfrom
conradbzura wants to merge 1 commit intomainfrom
Conversation
conradbzura
force-pushed
the
transpile-only-api
branch
from
fc3d72c to
d0b5f03
Compare
conradbzura
commented
Jan 29, 2026
|
|
||
|
|
||
| @dataclass | ||
| class Table: |
Collaborator
Author
There was a problem hiding this comment.
Simplified interval table definition.
- Add new public API: `transpile()` function and `Table` dataclass - Replace SchemaInfo/TableSchema/ColumnInfo with simpler Table/Tables types - Remove GIQLEngine, CLI, and dialect-specific generators - Delete integration tests that depended on execution engine - Update all generators and transformers to use new Table types
conradbzura
force-pushed
the
transpile-only-api
branch
from
d0b5f03 to
2cde79d
Compare
conradbzura
commented
Jan 29, 2026
| return container | ||
|
|
||
|
|
||
| def transpile( |
Collaborator
Author
There was a problem hiding this comment.
New API definition. Wondering if we should expose the Table fields here to make it easy to override the defaults without having to pass in a bunch of Table instances if they're all going to be using the same parameters...
Member
There was a problem hiding this comment.
We could do list[str | dict | Table], where the dict is unpacked into to the Table constructor so that missing keys are assigned default values.
nvictus
requested changes
Feb 4, 2026
Member
nvictus
left a comment
nvictus
left a comment
There was a problem hiding this comment.
- Add a (required) name attribute to
Table: e.g.,Table("foo", genomic_col="range") - For
transpile: Make thetablesparameterlist[str, Table]. Optionally, support dict elements in thetableslist. Remove thedict[str, Table]argument variant. - Change the constants:
DEFAULT_CHROM_COL = "chrom"
DEFAULT_START_COL = "start"
DEFAULT_END_COL = "end"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transpile()function andTabledataclass