Skip to content

fix: CompositeSpacePointLineFitter: Enable 3-hit fits and add sanity checks to the fitter#5083

Open
lmonaco99 wants to merge 11 commits intoacts-project:mainfrom
lmonaco99:SegFitter
Open

fix: CompositeSpacePointLineFitter: Enable 3-hit fits and add sanity checks to the fitter#5083
lmonaco99 wants to merge 11 commits intoacts-project:mainfrom
lmonaco99:SegFitter

Conversation

@lmonaco99
Copy link
Contributor

@lmonaco99 lmonaco99 commented Feb 10, 2026

  1. Enable the fast straw fit (with time) when having three measurements
  2. BugFix: remove the ToF correction during the conversion of the fast fitter result to the full fitter one. The fast calibrator is supposed to apply ToF correction by itself.
  3. Add additional sanity checks to the hessian. Now we check the determinant and the trace to ensure that the hessian is definite positive, which is the exact (sufficient) condition in the fast fitter (2x2), while a necessary (but still not sufficient) condition in the full fitter for N>2. This choice is to balance performances while catching the majority of invalid hessian cases

--- END COMMIT MESSAGE ---

@junggjo9

@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Feb 10, 2026
@github-actions github-actions bot added this to the next milestone Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

📊: Physics performance monitoring for aa8a891

Full contents

physmon summary

❗️: Downstream build failure

  • eic-shell (cc @acts-project/epic-contacts)

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Seeding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants