Harmonize theta pole check in Kálmán updater

[stephenswat]

The gain matrix updater currently uses two slightly different methods for checking for theta poles. This means that we sometimes fire an assertion even if the code for gracefully exiting in these cases did not fire. This commit harmonizes the pole checks so that they produce identical results. In the process, it deduplicates the checks to save on compute.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298341 to 298344 (+0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50264 to 50264 (+0.0%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	9bcb542	e790d83	Delta	9bcb542	e790d83
propagate_to_next_surface	7.83 ms	7.84 ms	0.1%	3.46	3.45
find_tracks	1.74 ms	1.62 ms	-6.5%	1.83	1.92
ccl_kernel	826.43 μs	824.04 μs	-0.3%	1.37	1.37
count_doublets	818.78 μs	817.92 μs	-0.1%	1.61	1.61
count_triplets	568.65 μs	566.87 μs	-0.3%	1.02	1.02
find_doublets	537.67 μs	534.59 μs	-0.6%	3.08	3.08
Thrust::sort	382.06 μs	382.14 μs	0.0%	7.30	7.30
find_triplets	170.83 μs	170.04 μs	-0.5%	1.32	1.31
build_tracks	125.03 μs	125.95 μs	0.7%	3.72	3.71
select_seeds	55.38 μs	54.51 μs	-1.6%	1.34	1.34
populate_grid	24.10 μs	24.09 μs	-0.0%	1.22	1.22
remove_duplicates	23.46 μs	23.46 μs	0.0%	26.20	26.16
count_grid_capacities	22.15 μs	22.20 μs	0.2%	1.22	1.22
fill_sorted_measurements	22.13 μs	22.10 μs	-0.1%	1.13	1.13
update_triplet_weights	16.83 μs	16.90 μs	0.4%	1.27	1.27
apply_interaction	14.98 μs	15.02 μs	0.2%	6.44	6.44
estimate_track_params	12.08 μs	12.09 μs	0.1%	2.69	2.69
fill_finding_propagation_sort_keys	9.86 μs	9.88 μs	0.2%	7.19	7.18
form_spacepoints	8.79 μs	8.79 μs	0.0%	1.48	1.48
reduce_triplet_counts	5.64 μs	5.64 μs	-0.0%	3.09	3.08
unknown	5.13 μs	5.12 μs	-0.3%	4.26	4.27
fill_finding_duplicate_removal_sort_keys	1.59 μs	1.59 μs	-0.1%	37.84	37.98
Total	13.22 ms	13.11 ms	-0.9%	2.99	3.01

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.