refactor(export): URL state persistence for citation export#771
Draft
thostetler wants to merge 6 commits intoadsabs:masterfrom
Draft
refactor(export): URL state persistence for citation export#771thostetler wants to merge 6 commits intoadsabs:masterfrom
thostetler wants to merge 6 commits intoadsabs:masterfrom
Conversation
thostetler
force-pushed
the
export-custom-format-url-state
branch
from
3b0bf66 to
26b82ec
Compare
User data should come fresh from the server session via dehydratedAppState on each page load. Persisting it to localStorage could cause stale auth data to override fresh session data.
When Select is used inside TabPanels or other stacking contexts, the dropdown menu can render behind other elements. Added menuPortal style with high z-index to support portaled menu rendering.
- Add localhost to CSP connect-src when mocking is enabled - Fix mock API base URL to use window origin for service worker interception - Generate valid mock token with proper expiry for authenticated testing - Add user-settings mock handler with sample custom formats
Added nuqs library and NuqsAdapter wrapper to enable type-safe URL query parameter state management in the application.
Removed XState machine in favor of simpler React state with draft/submitted pattern. Export options now persist to URL for shareability. - Replaced state machine with local useState for draft/submitted values - Added URL parameter parsing and serialization utilities - Custom format templates dropdown now uses portal for proper z-index - Added unit tests for URL param handling - Added e2e test for URL persistence
thostetler
force-pushed
the
export-custom-format-url-state
branch
from
26b82ec to
363e5aa
Compare
- Simplify redundant singleMode conditional check - Pass scalar values directly to field components instead of wrapping in arrays - Extract preserved search params into memoized helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export citation options now persist to URL query parameters, making export
configurations shareable and bookmarkable.