SCIX-826 Render feedback menu items as links for new-tab support#798
Open
thostetler wants to merge 2 commits intoadsabs:masterfrom
Open
SCIX-826 Render feedback menu items as links for new-tab support#798thostetler wants to merge 2 commits intoadsabs:masterfrom
thostetler wants to merge 2 commits intoadsabs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
========================================
+ Coverage 61.6% 61.6% +0.1%
========================================
Files 312 313 +1
Lines 36000 36092 +92
Branches 1594 1600 +6
========================================
+ Hits 22148 22232 +84
- Misses 13815 13823 +8
Partials 37 37
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback dropdown menu items used router.push() via onClick handlers,
which meant users could not Cmd+Click or right-click to open feedback
forms in a new tab. This forced users to lose their search results view
when navigating to feedback forms -- a problem when they need to
reference bibcodes from their results while filling out the form.