Adding the ability to write enums as strings.#43
Open
briespoke wants to merge 1 commit intoadzap:masterfrom
Open
Adding the ability to write enums as strings.#43briespoke wants to merge 1 commit intoadzap:masterfrom
briespoke wants to merge 1 commit intoadzap:masterfrom
Conversation
Owner
|
In principal I can see this would make things more consistent. The problem is it interferes with normal typecasting of strings to integers which can be passed to a write method in various scenarios. The result could be a nil when assigning a '1' for example. Not what we want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thank you for writing this module. It has improved the performance of my employer's application greatly.
We generally expect that a setter can accept a value from its own getter. However, when using ActiveEnum.use_name_as_value = true, enums must be written as either symbols or integers. Consider the following situation:
This behavior is counter-intuitive: a leaky abstraction. Particularly, it causes issues saving form data. This commit makes an enum accept strings, symbols and integers, fixing the leaky abstraction.
Take care and thank you for reviewing this request.