Continuous integration, version constraints#2
Open
ryancco wants to merge 4 commits intoaffise:masterfrom
Open
Conversation
introduce github actions
Unnecessary extension
Author
|
/cc @OlegBabakov would love any feedback to get this to pass. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Offers/OffersListDto.phpcausing psalm to fail - began failing after a hotfix for Typed property Affise\Sdk\Offers\OffersListDto::$notes must be string, null used #1 released in v0.1.1guzzlehttp/psr7:^1.7.0- supports usage of, for example,GuzzleHttp\Psr7\Headerinsrc/AbstractTransportguzzlehttp/guzzle:^6.5.2- supports usage of, for example,GuzzleHttp\Handler\MockHandler::createWithMiddleware()intests/Transpot/GuzzleTransportTest*.dist(see here for more)No breaking changes. Fixes the underlying issue addressed in #1 allowing
OffersListDto::getNotesto not break if thenotesproperty isnulldue to a strictstringreturn type.