Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR always adds a user
git-user. Theaddusercommand is inspired on your stalenon-rootbranch.My reason to always add a user, but not use, is to have the possibility to use it as a devcontainer in vscode.
I have a couple of repositories that I use to maintain my notes on various subjects. In vscode when you want to use a devcontainer as non-root, vscode requires to have that there is a user available in the container. There is no easy way to add it afterwards unless you create a new
Dockerfileand use that to build your own base-devcontainer. So by always adding the user, I can use this container in vscode really easily.I tried to pull your
alpine/git:userfrom docker hub, but that is too old and doesn't work with vscode.As far as I can see, adding this doesn't bother the current users who use the container as-is.