Update ubuntu.sh to install latest version of NodeJS#19
Open
poojasonawane27 wants to merge 1 commit intoamazon-science:mainfrom
Open
Update ubuntu.sh to install latest version of NodeJS#19poojasonawane27 wants to merge 1 commit intoamazon-science:mainfrom
poojasonawane27 wants to merge 1 commit intoamazon-science:mainfrom
Conversation
Member
|
@poojasonawane27 Thanks for your contribution! Could you please add an evaluation of the canonical solution file to show the evaluation changes one can expect after the nodejs version upgrade? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Install latest NodeJS, current code installs installs v12.22.9 which is not recommended to use.
Node recommends to use Node.js 14.17 and later. Ref: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#es2020-and-nodejs-1417-as-minimum-runtime-requirements
Commands taken from https://deb.nodesource.com/
Testing
Built the ubuntu docker image with these changes and verified the latest node version is installed
Executed a sample typescript task which was failing with previous version
Results:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.