feat(messages): add client-side validation for temperature, top_p, and top_k#1136
Open
Ashutosh0x wants to merge 1 commit intoanthropics:mainfrom
Open
feat(messages): add client-side validation for temperature, top_p, and top_k#1136Ashutosh0x wants to merge 1 commit intoanthropics:mainfrom
Ashutosh0x wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(messages): add client-side validation for temperature, top_p, and top_k
This PR adds client-side validation for sampling parameters to ensure they are within the ranges expected by the API, resolving #893.
Changes
validate_sampling_paramshelper function to enforce:temperature: 0.0 to 1.0top_p: 0.0 to 1.0top_k: >= 0Messages.create()andMessages.stream()(sync and async).Messages.create(),Messages.parse(),Messages.stream(), andMessages.tool_runner()(sync and async).Verification
Verified with a reproduction script testing both standard and beta resources with various invalid values. All tests passed, raising
ValueErroras expected instead of sending invalid requests to the API.