Skip to content

set scan executor names for meta and root #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith-turner merged 1 commit into from
Nov 21, 2025
Merged

set scan executor names for meta and root #5987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,19 +787,24 @@ private static abstract class DispatchParamsImpl implements DispatchParameters,

}

private static final ScanDispatch ROOT_SCAN_DISPATCH =
ScanDispatch.builder().setExecutorName("root").build();
private static final ScanDispatch META_SCAN_DISPATCH =
ScanDispatch.builder().setExecutorName("meta").build();

public void executeReadAhead(KeyExtent tablet, ScanDispatcher dispatcher, ScanSession<?> scanInfo,
Runnable task) {

task = ScanSession.wrap(scanInfo, task);

if (tablet.isRootTablet()) {
// TODO make meta dispatch??
Copy link
Member

@DomGarguilo DomGarguilo Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed in this PR but do you happen to know what these TODO comments mean?

Copy link
Contributor Author

@keith-turner keith-turner Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For user tables plugins can dispatch their scans to different executors. For the metadata and root tablets it hard coded which executors they will use for scans. Those comments are about those diffs.

scanInfo.scanParams.setScanDispatch(ScanDispatch.builder().build());
scanInfo.scanParams.setScanDispatch(ROOT_SCAN_DISPATCH);
task.run();
} else if (tablet.isMeta()) {
// TODO make meta dispatch??
scanInfo.scanParams.setScanDispatch(ScanDispatch.builder().build());
scanExecutors.get("meta").execute(task);
scanInfo.scanParams.setScanDispatch(META_SCAN_DISPATCH);
scanExecutors.get(META_SCAN_DISPATCH.getExecutorName()).execute(task);
} else {
DispatchParameters params = new DispatchParamsImpl() {

Expand Down