CASSANDRA-21130: Fix flakey tests due to tests updating SSTable format dynamically #4577
Conversation
| { | ||
| for (ColumnFamilyStore cfs : toPause) | ||
| { | ||
| successfullyPaused.ensureCapacity(successfullyPaused.size() + 1); // to avoid OOM after pausing the strategies |
There was a problem hiding this comment.
Would it not be safe to just fail hard on OOME?
There was a problem hiding this comment.
prob, this was mostly copy/paste to keep inline with w/e the reasoning was. I thought about making the methods public and marked as for tests vs copying... I don't think ColumnFamilyStore is a public API or consumed by a public API... but given that we really don't document whats public i didn't really want to take the risk
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Looks good, just a minor comment.
| * | ||
| * @param name the SSTable format name (e.g., "big" or "bti") | ||
| */ | ||
| public static void setUnsafeSelectedSSTableFormat(String name) |
There was a problem hiding this comment.
documentation says this Sets the global SSTable format after safely pausing all compactions., but the name has "unsafe" in it, should we update documentation or rename the method?
There was a problem hiding this comment.
i left it as unsafe as its doing something not actually supported yet. I can rename as its in test DD (I had it in DD before but didn't like it)
3 participants
No description provided.