CASSANDRA-21135 Fix JMXFeatureTest failure due to disabled AsyncProfiler #4585
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link: CASSANDRA-21135
Description:
This PR fixes a regression in
JMXFeatureTestcaused by the recently introduced Async Profiler (CASSANDRA-20854).Root Cause:
The
AsyncProfilerService.status()method was throwing anIllegalStateExceptionwhen the profiler was disabled (default state). During theJMXFeatureTest, the node restart process triggers JMX discovery/validation. When the test probe accessed theAsyncProfilerMBeanstatus, the exception caused the test to fail.Fix:
AsyncProfilerService.status()to return a descriptive String message ("Async Profiler is not enabled...") instead of throwing an exception when disabled.AsyncProfilerServiceTestto assert the message string instead of expecting an exception.Verification:
org.apache.cassandra.distributed.test.jmx.JMXFeatureTestpasses.org.apache.cassandra.service.AsyncProfilerServiceTestpasses.patch by Arvind Kandpal; for CASSANDRA-21135