framework-cluster: use bind.interface for cluster communication

[shwstppr]

Description

Fixes #11460

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

bind.interface is a bit misleading, maybe bind.address ?

[shwstppr]

@weizhouapache I'm not sure why it is named that way
https://github.com/apache/cloudstack/blob/main/client/conf/server.properties.in#L20
https://github.com/apache/cloudstack/blob/main/client/src/main/java/org/apache/cloudstack/ServerDaemon.java#L252

I didn't want to change the property name as it already exist

[weizhouapache]

ok, I see
let's keep the name

can you update the description in server.properties ?

[weizhouapache]

I checked the javadoc

https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/server/AbstractNetworkConnector.html#setHost(java.lang.String)

so IP/hostname/null/0.0.0.0 are valid values. maybe we need to consider them ?

[shwstppr]

IP/null/hostname should have been okay. I've added check for wildcards

[codecov]

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.76%. Comparing base (cd55796) to head (1141979).

Files with missing lines	Patch %	Lines
.../cloudstack/utils/server/ServerPropertiesUtil.java	0.00%	6 Missing ⚠️
...a/com/cloud/cluster/ClusterServiceServletImpl.java	88.23%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11797   +/-   ##
=========================================
  Coverage     17.76%   17.76%           
- Complexity    15860    15863    +3     
=========================================
  Files          5923     5923           
  Lines        530451   530474   +23     
  Branches      64815    64819    +4     
=========================================
+ Hits          94236    94250   +14     
- Misses       425674   425683    +9     
  Partials      10541    10541           

Flag	Coverage Δ
uitests	3.57% <ø> (ø)
unittests	18.85% <65.21%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15361

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16247