Skip to content

Conversation

@garydgregory
Copy link
Member

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • [No] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory force-pushed the feature/make_object_accessibility_optional branch from 728d79f to 751fc70 Compare January 9, 2026 16:11
@JeremySun0731
Copy link

Hi Gary,

I tried running mvn test on PR #1558 using IntelliJ’s bundled Maven and hit a Maven Enforcer failure:

Detected Maven Version: 3.6.3
Required: Maven >= 3.8.1

This seems to be due to the IDE default Maven version rather than the code itself.
I haven’t upgraded Maven locally yet, but wanted to report this environment behavior in case it’s relevant for contributors using IntelliJ defaults.

Happy to rerun tests with a newer Maven version if needed.

@garydgregory
Copy link
Member Author

That's correct, you need a recent version of Maven, not an ancient one 😉

@JeremySun0731
Copy link

While reviewing PR #1558 with LANG-1711 in mind, I noticed that not all reflective
access paths appear to be centralized in AbstractReflection yet.

In particular, ReflectionDiffBuilder still uses
FieldUtils.readField(field, target, true), which forces accessibility unconditionally
and bypasses the accessibleFlag mechanism introduced here.

This means the new opt-in accessibility strategy does not currently apply
to ReflectionDiffBuilder in the same way as ReflectionToStringBuilder and others.

@JeremySun0731 JeremySun0731 mentioned this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants