-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feature : Make object accessibility optional #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature : Make object accessibility optional #1558
Conversation
make object accessibility optional
728d79f to
751fc70
Compare
|
Hi Gary, I tried running Detected Maven Version: 3.6.3 This seems to be due to the IDE default Maven version rather than the code itself. Happy to rerun tests with a newer Maven version if needed. |
|
That's correct, you need a recent version of Maven, not an ancient one 😉 |
|
While reviewing PR #1558 with LANG-1711 in mind, I noticed that not all reflective In particular, ReflectionDiffBuilder still uses This means the new opt-in accessibility strategy does not currently apply |
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.