Improve test coverage for TypeUtils.isAssignable() #1574
Merged
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LANG-1812] Test: Expose and test TypeUtils.isAssignable to improve coverage
Jira Link : Click here
Description
The method
TypeUtils.isAssignable(Type, TypeVariable, Map)currently has 0% coverage because the branch involving thetypeVarAssignsmap is never exercised in the existing test suite.I have created a new test case (
testIsAssignable_Type_TypeVariable_Map) to fix this.Changes:
privatemodifier fromisAssignableto make it package-private (allowing access for testing).TypeVariableand a corresponding map to verify the method correctly processes map arguments.Result:
This change increases the branch coverage of the
reflectpackage from 78% to 79%.Coverage Evidence
Before

After

Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.