Skip to content

Conversation

@GitToTheHub
Copy link
Contributor

@GitToTheHub GitToTheHub commented Feb 9, 2026

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Fix an issue where menu entries weren't being highlighted or scrolled to when navigating between documentation pages, particularly affecting nested entries without children (e.g., "Security" under "Security & Privacy").
- Normalize URLs to handle Jekyll's pretty URLs (e.g., "path/") vs TOC entry URLs (e.g., "path/index.html") for proper comparison
- Add validation to prevent false matches on pages without URLs
- Fixes: #1417
- Generated-By: Claude Sonnet 4.5
@GitToTheHub GitToTheHub changed the title fix(toc): highlight toc entries without sub-entries fix(toc): highlight toc entries pointing to section/index.html Feb 9, 2026
@GitToTheHub GitToTheHub changed the title fix(toc): highlight toc entries pointing to section/index.html fix(toc): highlight toc entries pointing to index.html Feb 9, 2026
- It's enough to just replace `index.html` with an empty string
@GitToTheHub GitToTheHub changed the title fix(toc): highlight toc entries pointing to index.html fix(toc): highlight toc entries pointing to index.html on desktop Feb 10, 2026
- This is used on mobile devices. Since the css is not properly configured for the dropdown the highlighting cannot be seen
@GitToTheHub GitToTheHub changed the title fix(toc): highlight toc entries pointing to index.html on desktop fix(toc): highlight toc entries pointing to index.html Feb 10, 2026
@GitToTheHub
Copy link
Contributor Author

This is ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu entries without sub entries should be highlighted and scrolled to

1 participant