Fix verify-release-candidate script by removing reference to requirements-310.txt#1012
Merged
alamb merged 2 commits intoapache:mainfrom Feb 5, 2025
Merged
Fix verify-release-candidate script by removing reference to requirements-310.txt#1012alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
timsaucer
approved these changes
Feb 3, 2025
viirya
reviewed
Feb 3, 2025
| python3 -m venv .venv | ||
| source .venv/bin/activate | ||
| python3 -m pip install -U pip | ||
| python3 -m pip install -r requirements-310.txt |
Member
There was a problem hiding this comment.
I need to add python3 -m pip install -U maturin to make the verify script work locally.
Contributor
There was a problem hiding this comment.
that makes sense, we create and activate a new venv right above
Looks like requirements-310.txt was removed in #994
kevinjqliu
reviewed
Feb 3, 2025
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Contributor
Author
|
Thanks @kevinjqliu -- I merged your suggestion and tested that running the following passed ✅ $ ./dev/release/verify-release-candidate.sh 44.0.0 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When verifying the release using
./dev/release/verify_release_candidate.sh 44.0.0 1I got the following errorWhen I commented out the line everything worked great
See the email list for more information: https://lists.apache.org/thread/gkk4lq6k19gcq9xw64mcmbxrnf68o95s
What changes are included in this PR?
Remove line that was erroring
Are there any user-facing changes?