refactor: collect dataframe as stream in __repr__#1015
refactor: collect dataframe as stream in __repr__#1015konjac wants to merge 4 commits intoapache:mainfrom
__repr__#1015Conversation
…to repr-without-adding-limit
|
Hi @timsaucer , could you help to trigger CI and also review the proposed change? Thank you! |
…ious stream of batches. Also refactor _repr_html_.
timsaucer
left a comment
There was a problem hiding this comment.
This looks good. It took me a while to parse through the logic of the get_batches. I think it's worth adding some documentation within the file to explain why we are doing this so that future maintainers can understand the necessity of doing it this way.
Thank you for the PR!
Thank you for the reviewing! A new iteration is pushed to add code comments. |
|
Original problem was resolved by #1036 which I believe used part of this work. Thank you very much for the contribution! |
Which issue does this PR close?
Closes #1014.
Rationale for this change
The root cause for #1014 is
_repr_appends a limit clause and causes EXPLAIN not the top plan.What changes are included in this PR?
This change refactors
_repr_to collect the dataframe as a stream.Before the change,
After the change
Are there any user-facing changes?
No. Bugfix only.