pyo3 update required changes to deprecated interfaces#1030
Closed
timsaucer wants to merge 3 commits intoapache:mainfrom
Closed
pyo3 update required changes to deprecated interfaces#1030timsaucer wants to merge 3 commits intoapache:mainfrom
timsaucer wants to merge 3 commits intoapache:mainfrom
Conversation
kevinjqliu
approved these changes
Feb 19, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I verified locally by running
cargo clippy --all-targets --all-features -- -D clippy::all -D warnings -A clippy::redundant_closure
Contributor
|
I added this PR to #1029 to check CI and everything is green! |
Member
Author
|
Closing in favor of #1029 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, but it supports PR #1029
Rationale for this change
pyo3 update recently introduced a lot of warnings about deprecated APIs. This PR addresses those warnings.
What changes are included in this PR?
Changed to new interfaces and associated error returns.
Are there any user-facing changes?
None