Improved window and aggregate function signature#1187
Merged
timsaucer merged 1 commit intoapache:mainfrom Aug 21, 2025
Merged
Conversation
…ons for partition_by and order_by
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
This is a relatively minor change that allows users to pass a single expression for
order_byandpartition_byfields.Without this change, if used improperly planning gets stuck in a loop. This improves ergonomics.
Old version required:
and now you can also write
What changes are included in this PR?
Enhances the check to see if we pass a single expression. When this is true, wrap it in a list. Added unit tests.
Are there any user-facing changes?
This is a non-breaking signature change. It is backwards compatible.