feat: allow passing a slice to and expression with the [] indexing#1215
Merged
timsaucer merged 3 commits intoapache:mainfrom Sep 5, 2025
Merged
feat: allow passing a slice to and expression with the [] indexing#1215timsaucer merged 3 commits intoapache:mainfrom
timsaucer merged 3 commits intoapache:mainfrom
Conversation
alamb
approved these changes
Sep 4, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @timsaucer -- I have a suggestion about testing, but otherwise looks good to me
| ), | ||
| ( | ||
| lambda col: col[literal(1) : literal(4) : literal(2)], | ||
| lambda data: [arr[1:4:2] for arr in data], |
Contributor
There was a problem hiding this comment.
should we also test non literal expressions? Even if they are supposed to error?
Member
Author
There was a problem hiding this comment.
They will not error. Unit test added to demonstrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a user request but no issue was opened.
Rationale for this change
With this you can do slicing of arrays via expression. For example, suppose you have this data frame:
You could do
df.with_column("a[1:3]", column("a")[1:3])to getWhat changes are included in this PR?
Updates
__getitem__to take slice.Adds unit tests.
Are there any user-facing changes?
No
TODO