Conversation
45 tasks
nuno-faria
reviewed
Sep 16, 2025
Cargo.toml
Outdated
Comment on lines
67
to
71
| [patch.crates-io] | ||
| datafusion = { git = "https://github.com/apache/datafusion.git", branch = "branch-50" } | ||
| datafusion-substrait = { git = "https://github.com/apache/datafusion.git", branch = "branch-50" } | ||
| datafusion-proto = { git = "https://github.com/apache/datafusion.git", branch = "branch-50" } | ||
| datafusion-ffi = { git = "https://github.com/apache/datafusion.git", branch = "branch-50" } |
Contributor
There was a problem hiding this comment.
Thanks @timsaucer for the PR. datafusion 50 has now been released, so I think this is now ready.
1ab3c4a to
32ab61d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Prepare for next release and test DF50
Rationale for this change
Next release
What changes are included in this PR?
The following changes were required:
approx_percentile_contandapprox_percentile_cont_with_weightto take in sort expressions and number of centroidsAre there any user-facing changes?
Addition only