-
Notifications
You must be signed in to change notification settings - Fork 143
Introduce Table wrapper, unify table registration via register_table; deprecate legacy APIs #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9b4f144
Migrate Table → TableProvider; refactor registration and access, update
kosiew 3da3f93
Refactors and bug fixes around TableProvider registration and
kosiew 512442b
TableProvider refactor & PyDataFrame integration
kosiew a8275dc
Normalize & simplify TableProvider/DataFrame registration; add
kosiew 00bd445
refactor: update documentation for DataFrame to Table Provider conver…
kosiew 6869919
refactor: replace to_view_provider with inner_df for DataFrame access
kosiew 6e46d43
refactor: streamline TableProvider creation from DataFrame by consoli…
kosiew 38af2b5
Merge branch 'main' into table-provider-1239
kosiew 1872a7f
fix ruff errors
kosiew 5948fb4
refactor: enhance autoapi_skip_member_fn to skip private variables an…
kosiew b9851d8
revert main 49.0.0 md
kosiew 586c2cf
refactor: add comment in autoapi_skip_member_fn
kosiew d4ff136
refactor: remove isort and ruff comments to clean up import section
kosiew 29203c6
docs: enhance docstring for DataFrame.into_view method to clarify usa…
kosiew ae8c1dd
docs: update example in DataFrame.into_view docstring for clarity
kosiew 0c5eb17
docs: update example for registering Delta Lake tables to simplify usage
kosiew f9a3a22
docs: update table provider documentation for clarity and deprecate o…
kosiew f930181
docs: update documentation to reflect removal of TableProvider and us…
kosiew afc9b4e
remove TableProvider in Python, update missing_exports function, doc
kosiew 918b1ce
Fix Ruff errors
kosiew 93f0a31
Refactor test_table_loading to use Table instead of TableProvider
kosiew 7bc303d
Refactor aggregate tests to simplify result assertions and improve re…
kosiew 4429614
Add comments to clarify table normalization in aggregate tests
kosiew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example takes a bit of cognitive load to understand what we're demonstrating.
First off, similar to my comments above I don't think we want our users to have to think about if they're using something that comes from a PyCapsule interface or not. Suppose I am a library user and I get a delta table object that implements PyCapsule. As a user of that library, I shouldn't have to understand how the interfacing works. I should just be able to use it directly. So I want to be able to just pass those objects directly to
TableProviderorregister_tablewithout having to think about or understand these mechanics behind the scene.