Do not convert pyarrow scalar values to plain python types when passing as lit#1319
Merged
timsaucer merged 2 commits intoapache:mainfrom Jan 5, 2026
Merged
Conversation
Member
Author
|
Failure demonstration with prior code: Same test passing with new code: |
Member
Author
|
@abey79 FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
An early version of the
lit()code used conversion of pyarrow scalars into python objects and then using the bare python types to determine what kind of scalar value to create. We can use the pyarrow scalar objects directly in our call topa.array()instead and get lossless conversion.What changes are included in this PR?
lit()Are there any user-facing changes?
No
Note
The unit test was LLM generated but it looks complete to me.