feat: support enable_url_table config#980
Merged
timsaucer merged 3 commits intoapache:mainfrom Jan 8, 2025
Merged
Conversation
Member
|
Thank you for the addition! Would it be simpler to just expose the function on the session context instead of making it part of the initialization? Even if you do think it's important to have it in initialization, we probably should expose the function also to maintain parity with the rust version. |
Contributor
Author
updated |
timsaucer
approved these changes
Jan 8, 2025
Member
|
Very nice. Thank you. I've kicked off CI and will merge if all goes through. |
timsaucer
reviewed
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
without url table support, we have to create table, if we want to query a file.
What changes are included in this PR?
support enable_url_table config
Are there any user-facing changes?
No