Merged
Conversation
amogh-jahagirdar
approved these changes
Mar 22, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @singhpk234 !
Comment on lines
+40
to
+41
| ENV ICEBERG_VERSION=1.2.0 | ||
| ENV AWS_SDK_VERSION=2.20.18 |
Contributor
There was a problem hiding this comment.
Nice, thanks for cleaning this up!
Fokko
approved these changes
Mar 22, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for updating this @singhpk234
Fokko
reviewed
Mar 22, 2023
| description: What Apache Iceberg version are you using? | ||
| multiple: false | ||
| options: | ||
| - "1.1.0 (latest release)" |
Contributor
There was a problem hiding this comment.
Maybe we should make this part of the How to release process? https://iceberg.apache.org/how-to-release/
Contributor
There was a problem hiding this comment.
good point, I have a PR open for updating release process, looks like this and also REV API update needs to be added apache/iceberg-docs#210
jackye1995
reviewed
Mar 22, 2023
jackye1995
reviewed
Mar 22, 2023
singhpk234
force-pushed
the
update/python-dev-Dockerfile
branch
from
6c7a1fc to
aaeb1ad
Compare
Contributor
Author
|
mostly picked the docker changes from tabular-spark image. |
Contributor
|
Thanks @singhpk234 for the contribution! And thanks for the review @Fokko and @amogh-jahagirdar ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change focuses mainly to make sure docker file uses the most recent set-up as per 1.2.0 release
[1] AWS SDK changed to 2.20.18
[2]
url-connection-client is no longer required(It's present in master only at the moment)[3] minor refactoring
Also updates iceberg_bug_report yml with recent version.
cc @jackye1995 @Fokko