[ISSUE #196] Fix serviceAccountName inconsistency

[sinloss]

What is the purpose of the change

Closes #196

Brief changelog

Change the serviceAccountName in the operator.yaml to {{ template "rocketmq-operator.serviceAccountName" . }}, the same as in the role_binding.yaml and service_account.yaml.

Verifying this change

This works on a Kubernetes v1.25.4 cluster with 2 nodes, via Helm version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.3"}.

Please go through this checklist to help us incorporate your contribution quickly and easily.

Notice: It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.

• Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Check RBAC rights for Kubernetes roles.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
• Run make docker-build to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.
• Before committing your changes, remember to run make manifests to make sure the CRD files are updated.
• Update documentation if necessary.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[caigy]

This file is copied from that one in deploy directory(see the link below), pls also change the original file.
https://github.com/apache/rocketmq-operator/blob/a8665716c8028741ec106814798e39fe07e6dcaa/Makefile#L78C1-L88

[sinloss]

Sure, I'll go through it once I have time. Please bear with me for a couple of days.

[caigy]

Files in deploy directory are for deploying by kubectl instead of helm, so templating is not supported.
@drivebyer Pls also take a look, it seems some substitution operations should be added in make manifest.

[sinloss]

Sure!

[drivebyer]

For now, After we execute make manifest , the templating in chart directory disappeared.

I would find some way to do substitution in make manifest.

[drivebyer]

Maybe we can generate chart by helmify, #212

[sinloss]

Finally got some time for this one. So basically, if I understand it right, and correct me if I'm not, that those yaml files in the deploy directory don't just serve one purpose which is to be copied to the templates directory, they are also being used directly by the kubectl command.

And to fix what I want to fix, something needs to be done in the make manifest process to properly generate / or recreate / or substitute after copying / or any other ways possible yaml files with helm templating contents in the templates directory while at the same time keep yaml files in the deploy directory free from helm templating contents.

The thing is, am I allowed to choose whatever means possible to achieve this or should I wait for some discussions to reach a conclusion and then go on with this PR?

[caigy]

@sinloss IMO we should fix bugs in make manifest to generate correct files in deploy (for kubectl) and charts (for helm). Pls check if #212 can achieve it.