Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Jan 24, 2026

Check TEZ-4683 for information.
Screenshot 2026-01-24 at 11 09 42 PM
Screenshot 2026-01-24 at 11 22 58 PM
verified using the regex as well. (Only 3rd one is wrong)

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 8m 54s master passed
+1 💚 compile 0m 21s master passed
+1 💚 checkstyle 0m 45s master passed
+1 💚 javadoc 0m 31s master passed
-1 ❌ spotbugs 0m 59s /branch-spotbugs-tez-api.txt tez-api in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 16s the patch passed
+1 💚 codespell 0m 28s No new issues.
+1 💚 compile 0m 15s the patch passed
+1 💚 javac 0m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 6s the patch passed
+1 💚 javadoc 0m 15s the patch passed
-1 ❌ spotbugs 0m 14s /patch-spotbugs-tez-api.txt tez-api in the patch failed.
_ Other Tests _
+1 💚 unit 1m 52s tez-api in the patch passed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
16m 21s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-455/1/artifact/out/Dockerfile
GITHUB PR #455
Optional Tests dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname Linux ed6050731fbb 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-455/src/.yetus/personality.sh
git revision master / 826b364
Default Java Ubuntu-21.0.9+10-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-455/1/testReport/
Max. process+thread count 290 (vs. ulimit of 5500)
modules C: tez-api U: tez-api
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-455/1/console
versions git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review January 24, 2026 18:36
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic bug, good catch! LGTM

@abstractdog
Copy link
Contributor

epic bug, good catch! LGTM

corresponding unit tests pass with the patch (TestZkFrameworkClient, TestZkAMRegistryClient)

@abstractdog abstractdog merged commit ffd346b into apache:master Jan 24, 2026
4 checks passed
@Aggarwal-Raghav Aggarwal-Raghav deleted the TEZ-4683 branch January 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants