-
Notifications
You must be signed in to change notification settings - Fork 158
feat: Better describe the circumstances under which run usage info is included in API responses #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…s included in API responses
|
Preview for this PR was built for commit |
| nullable: true | ||
| description: >- | ||
| Platform usage costs breakdown in USD. Only present if you own the run AND are paying for platform usage | ||
| (Pay-Per-Usage, Rental, or Pay-Per-Event with usage costs like standby Actors). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am technically missing there "if you are Actor owner" case - you are then only paying for usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like too much detail to me honestly...
| description: >- | ||
| Total cost in USD for this run. Represents what you actually pay. | ||
| For run owners: includes platform usage (compute units) and/or event costs depending on the Actor's pricing model. | ||
| For non-owners: only available for Pay-Per-Event actors (event costs only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe specify that "run non-owners"? I know, it is a bit complicated.
| nullable: true | ||
| description: >- | ||
| Total cost in USD for this run. Represents what you actually pay. | ||
| For run owners: includes platform usage (compute units) and/or event costs depending on the Actor's pricing model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on pricing model - yes - but also depends on "if you own the Actor" 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this is written under "For run owners:", so the "if you own the Actor" condition is already satisfied, right?
stetizu1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept some suggestions, but overall ok 😅
Co-authored-by: Zuzana Štětinová <40138689+stetizu1@users.noreply.github.com>
Co-authored-by: Zuzana Štětinová <40138689+stetizu1@users.noreply.github.com>
|
Preview for this PR was built for commit |
1 similar comment
|
Preview for this PR was built for commit |
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
|
Preview for this PR was built for commit |
Note
Improves OpenAPI docs and simplifies schema for run usage fields.
usageTotalUsdandusageUsdspecifying availability based on ownership and Actor pricing modelsusageandusageUsddefinitions by replacingallOf/oneOfcomposition withnullable: trueand direct$reftoRunUsage.yamlWritten by Cursor Bugbot for commit d92e3f1. Configure here.