buildkit proto followProgress support#824
Open
davidgamero wants to merge 2 commits intoapocas:masterfrom
Open
Conversation
Add docker.followProgress() method that works like docker.modem.followProgress() but automatically decodes BuildKit v2 build logs. Works transparently with both regular and BuildKit streams (build, pull, push, etc.). Proto types match the official moby/buildkit control.proto schema.
davidgamero
force-pushed
the
buildkit-progress
branch
from
4366364 to
811d9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expanding on the work in #766 to create a
docker.followProgressthat behaves likedocker.model.followProgressfor non-buildkit streams, but unmarshals the protobuf when buildkit logs are detected.followed existing repo pattern for buildkit .proto definitions in /lib/proto, then adding decoding logic in a dedicated method via
protoLoader.loadSyncto read the definitions.happy to upstream this into modem or a smaller helper if that is the better place to put it, or break this up into smaller PRs to make reviewing easier
tried to align with the repo philosophy on streams:
resolves #795
collab credit @bosesuneha