Corrected determining the path for the Entitlements#37
Open
jbattersby-gg wants to merge 1 commit intoapple:mainfrom
Open
Corrected determining the path for the Entitlements#37jbattersby-gg wants to merge 1 commit intoapple:mainfrom
jbattersby-gg wants to merge 1 commit intoapple:mainfrom
Conversation
Andrew-Grabish-HypGames
pushed a commit
to HypGamesOrlando/unityplugins
that referenced
this pull request
Sep 17, 2024
To more easily integrate into developer CI systems, deferring code signing until the generated Xcode project is being built is ideal. To support this, I've updated the shell script that embeds libraries to also code sign binaries when embedding. Importantly, this final code sign step will use the same code signing identity that developers configure the generated Xcode project to use. This ensures that the code signing identity used for the rest of the app is also used to sign the native libraries copied into the generated Xcode project by Apple.Core. So now developers can: 1. Build and sign libraries when they build with build.py, if they choose. This allows down stream consumers of the plug-ins to validate binary origin. 2. Consume plug-in libraries in their projects without having to pay attention to code signing identity; all libraries will automatically be re-signed with the code signing identity used by Xcode when building the generated Xcode project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity provides convenient methods for acquiring the entitlements file in Apple projects. The current version incorrectly appends the product name to the existing entitlements path and can't be found by the resulting Xcode project