Skip to content

separate unreserve_vlan and update_bw in delete_connection#298

Merged
YufengXin merged 3 commits intomainfrom
169-hide-implementation-details
Dec 10, 2025
Merged

separate unreserve_vlan and update_bw in delete_connection#298
YufengXin merged 3 commits intomainfrom
169-hide-implementation-details

Conversation

@YufengXin
Copy link
Collaborator

No description provided.

@YufengXin YufengXin self-assigned this Nov 12, 2025
@YufengXin YufengXin linked an issue Nov 12, 2025 that may be closed by this pull request
@YufengXin YufengXin marked this pull request as draft November 12, 2025 15:06
@coveralls
Copy link

coveralls commented Nov 12, 2025

Pull Request Test Coverage Report for Build 19307816920

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 91.09%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sdx_pce/topology/temanager.py 4 5 80.0%
Totals Coverage Status
Change from base Build 18196807589: -0.005%
Covered Lines: 1448
Relevant Lines: 1566

💛 - Coveralls

@YufengXin YufengXin closed this Nov 12, 2025
@YufengXin YufengXin reopened this Nov 12, 2025
@YufengXin YufengXin changed the title unprivatize temanager.reserve_vlan_breakdown() for failure handling separate unreserve_vlan and update_bw in delete_connection Nov 13, 2025
@YufengXin
Copy link
Collaborator Author

Copy link
Contributor

@italovalcy italovalcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YufengXin YufengXin merged commit 2f064b7 into main Dec 10, 2025
4 checks passed
@YufengXin YufengXin deleted the 169-hide-implementation-details branch December 10, 2025 19:24
@YufengXin YufengXin restored the 169-hide-implementation-details branch December 10, 2025 20:04
@YufengXin YufengXin deleted the 169-hide-implementation-details branch December 10, 2025 20:04
@YufengXin YufengXin restored the 169-hide-implementation-details branch December 10, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide implementation details

3 participants