Open
Conversation
Pull Request Test Coverage Report for Build 21446560245Details
💛 - Coveralls |
italovalcy
reviewed
Feb 11, 2026
| f"Removing connection: {service_id} {connection.get('status')}" | ||
| ) | ||
| _, code = self.remove_connection(te_manager, connection["id"]) | ||
| _, code = self.remove_connection( |
Contributor
There was a problem hiding this comment.
@congwang09 please help me understand here: will this code remove the user request from database once there is failure? I think rather than removing, we should just make the connection as state=down, no? Sorry if I misunderstood the ideia here.
Contributor
Author
There was a problem hiding this comment.
Yes, I think we had some discussion earlier, we would mark connection status as error and remove a connection if connection contains failed links. We can definitely discuss how we should handle this situation. This would be a relatively big change, so we can probably update this in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #399
Add a "reason" field for archived connection.
reason can be:
API: user deletes connection
Failure: connection deleted because of failure