Add unit tests for L2VPN state machine transitions#515
Open
Add unit tests for L2VPN state machine transitions#515
Conversation
Pull Request Test Coverage Report for Build 21653251912Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new unit tests to validate the current and desired behavior of the L2VPN connection state machine.
Important:
This PR does not modify any production code in
sdx-controller(no changes tosdx_datamodel.connection_sm,connection_handler.py, or any other module).It only introduces new test cases in the new file
test_connection_state_machine.pyto document and verify the state machine behavior.These tests are intended to:
This PR closes atlanticwave-sdx/datamodel#199
(and builds upon the context from atlanticwave-sdx/datamodel#184).
What the tests verify
The new tests cover the following specific requirements:
test_maintenance_state_exists)Current test results (as of this PR)
Reason for the two xfailed tests:
The current
connection_state_machine()implementation does not raise ConnectionSMException for these transitions.The xfailed status serves as a marker that these transitions still need proper implementation / validation in a future PR.
Related issues