Conversation
yacovm
reviewed
Feb 17, 2026
sched.go
Outdated
|
|
||
| // ScheduleOrReplace schedules a task, replacing any queued task if full. | ||
| // The cancel function is called before draining the old task. | ||
| func (as *BasicScheduler) ScheduleOrReplace(task Task, cancel func()) { |
Collaborator
There was a problem hiding this comment.
why not just invoke e.blockBuilderCancelFunc outside, in the epoch?
Collaborator
Author
There was a problem hiding this comment.
because we wont know if we need to cancel it until we grab the lock
Collaborator
There was a problem hiding this comment.
But we can cancel it anyway, no?
Collaborator
Author
There was a problem hiding this comment.
yea we do, removed
yacovm
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.