Apply more conventional code style linting#49
Open
greena13 wants to merge 1 commit intoavocode:masterfrom
greena13:linting
Open
Apply more conventional code style linting#49greena13 wants to merge 1 commit intoavocode:masterfrom greena13:linting
greena13 wants to merge 1 commit intoavocode:masterfrom
greena13:linting
Conversation
|
Maybe Prettier can be added too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository has some pretty unconventional linting. To encourage contributions from the community and to make it easier to read and maintain the source code, I took a look at the linting rules of some of the most popular react projects:
https://github.com/kriasoft/react-starter-kit/blob/master/.eslintrc.js
https://github.com/callemall/material-ui/blob/v1-beta/.eslintrc.js
https://github.com/facebook/react/blob/master/.eslintrc.js
And removed any rules that I saw as noticeable deviations from what seems to be a pretty safe proxy for community standard.
I then ran
To autofix all JS files with the new linting rules and fixed any refactoring that could not be performed automatically.
There are still linting issues with the test files, but I am planning on addressing those in a subsequent pull request.