Refactor test suite#52
Open
greena13 wants to merge 1 commit intoavocode:masterfrom
greena13:refactor_tests
Open
Refactor test suite#52greena13 wants to merge 1 commit intoavocode:masterfrom greena13:refactor_tests
greena13 wants to merge 1 commit intoavocode:masterfrom
greena13:refactor_tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the test suite's structure, readability and coverage.
Changes
Testing dependencies
test/setup.jsfilemocha.optsconfiguration file for easier configuration of how the test suite runsStructure
beforeEachblocks of common contexts where possible<Shortcuts />into multiple files for easier navigationSyntax
React.createElementandReact.DOMReact.findDOMNodeto a single place, so it will be easier to swap out at a later point (I couldn't figure out how to remove the deprecated method completely)Coverage
Limitations
isolateprop through writing tests and reading the source code - this may be because of the way events are simulated in the test suite or something else I am not getting.Conflicts