fix: convert Unix timestamps in Lambda input #270
Merged
+144
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix TypeError when parsing Lambda invocation events containing Unix millisecond timestamps. The backend sends timestamps as integers, but the code expected datetime objects for comparison operations. Note this problem does NOT occur on Checkpoint and Get Execution State, because these benefit from the boto deserializer creating DateTime objects. It only impacts the input to the lambda. The bug manifested in concurrent execution (map/parallel) when operations had PENDING status with NextAttemptTimestamp. The code attempted to compare the integer timestamp with datetime.now(), causing: TypeError: '<' not supported between instances of 'int' and 'datetime.datetime' Changed execution.py to use from_json_dict() instead of from_dict() when parsing Lambda events. The from_json_dict() method properly converts Unix millisecond timestamps to datetime objects using TimestampConverter. Added regression tests covering all timestamp fields: - StartTimestamp - EndTimestamp - StepDetails.NextAttemptTimestamp - WaitDetails.ScheduledEndTimestamp The bug only affected Lambda invocations, not unit tests, because tests inject pre-constructed objects that bypass event parsing. closes #269
wangyb-A
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeError when parsing Lambda invocation events containing Unix millisecond timestamps. The backend sends timestamps as integers, but the code expected datetime objects for comparison operations.
Note this problem does NOT occur on Checkpoint and Get Execution State, because these benefit from the boto deserializer creating DateTime objects. It only impacts the input to the lambda.
The bug manifested in concurrent execution (map/parallel) when operations had PENDING status with NextAttemptTimestamp. The code attempted to compare the integer timestamp with datetime.now(), causing: TypeError: '<' not supported between instances of 'int' and 'datetime.datetime'
Changed execution.py to use from_json_dict() instead of from_dict() when parsing Lambda events. The from_json_dict() method properly converts Unix millisecond timestamps to datetime objects using TimestampConverter.
Added regression tests covering all timestamp fields:
The bug only affected Lambda invocations, not unit tests, because tests inject pre-constructed objects that bypass event parsing.
closes #269
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.