This repository was archived by the owner on May 21, 2025. It is now read-only.
issue-144 Using aws-lambda-go-api-proxy to enable echo Framework and Lambda with ALB#146
Open
ikegam1 wants to merge 3 commits intoawslabs:masterfrom
Open
issue-144 Using aws-lambda-go-api-proxy to enable echo Framework and Lambda with ALB#146ikegam1 wants to merge 3 commits intoawslabs:masterfrom
ikegam1 wants to merge 3 commits intoawslabs:masterfrom
Conversation
|
Hello, any chance that this PR will get a look. |
|
I tried merge this PR into my fork and it is working very well. And I even successfully added fiberadapter for ALB on top of this PR. It could be great if we can get this PR merged into this main awslabs repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #144
Description of changes:
I used aws-lambda-go-api-proxy to use echo Framework and Lambda with ALB.
However, it failed because the response type from Lambda to ALB is different.
To support this, I made an adapter for echo.
The base is the code of the api gateway.
Details
ALB event format
https://docs.aws.amazon.com/lambda/latest/dg/services-alb.html
example (code fragment)
An example using sam can be found here
go test result
debug result
request & response
cloud watch logs(debug)
Please confirm.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.