Open
Conversation
JRuby.runtime.current_context is more future proof
the Method/UnboundMethod#source_location replacements on JRuby made no sense - they simply delegated to what was already available. this might date back to JRuby 1.7 where these hacks would provide source_location for Ruby 1.8(.7) mode
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the first commit replaces the internals with another piece (which is future proof on JRuby)
the seconds removes the hacks to just rely on what
source_locationalready provides(the only downside I can think of is that this would break 1.8 mode for long dead JRuby 1.7.x)