separate 'framebuffer' 💻 and friends to own crate ➗ #388
Open
ivy-rew wants to merge 2 commits intobaskerville:masterfrom
Open
separate 'framebuffer' 💻 and friends to own crate ➗ #388ivy-rew wants to merge 2 commits intobaskerville:masterfrom
ivy-rew wants to merge 2 commits intobaskerville:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @baskerville
A guy had a great idea re-use your framebuffer and Kobo-device support implementation in order to run a VNC client on Kobo devices.
This started with copy and paste work from plato; but it would be great to have this logic in its own crate to serve the community 🤝 .
I assume that it also simplifies the development of plato itself. As we can separate the somewhat heavier build deps (mupdf) from the display and therefore simplify the build ✔️ .
At any rate, it would make it obsolete for me to copy support for new devices from you 😉
ivy-rew/eink-vnc@33cc8ce
I've made a first protoype of this. Could you think of going that path to split your crates 🤔 ?
Have you ever thought of publishing plato to crate.io 📦 in order to let other users build upon your fantastic work here?
Feel free to suggest a better name for the
displaycrate. I could also think of calling itkobo-eink, orplato-display... any preferences?