Skip to content

Conversation

@dabanki
Copy link
Contributor

@dabanki dabanki commented Dec 18, 2025

These flags have been identified as obsolete. We are removing their references from Bazel as precursor work towards Starlarkifying Apple related flags, eventually removing the fragment all together.

See bazelbuild/rules_apple#2845.

@dabanki dabanki requested a review from gregestren December 18, 2025 19:59
@dabanki dabanki marked this pull request as ready for review December 18, 2025 20:45
@dabanki dabanki requested a review from lberki as a code owner December 18, 2025 20:45
@github-actions github-actions bot added team-Rules-ObjC Issues for Objective-C maintainers awaiting-review PR is awaiting review from an assigned reviewer labels Dec 18, 2025
case DBG:
ImmutableList.Builder<String> opts = ImmutableList.builder();
if (!this.avoidHardcodedCompilationFlags) {
opts.addAll(DBG_COPTS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the story on removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some references internally - and this function itself should be converted to starlark and replace the usages. I wanted to handle that in a separate task, but once it's not referenced anymore it should be fine to delete!

@dabanki
Copy link
Contributor Author

dabanki commented Dec 19, 2025

cc @keith, @brentleyjones

@keith
Copy link
Member

keith commented Dec 19, 2025

LGTM, notes:

  • experimental_objc_fastbuild_options - i've been trying to remove this one for a while Remove --experimental_objc_fastbuild_options #27504
  • ios_signing_cert_name / signing_certificate_name - this one is currently used in rules_apple but looks like it could probably be removed
  • objc_debug_with_GLIBCXX - I don't think this was ever really used, but it just adds some -D flags so either way i think it's fine
  • incompatible_avoid_hardcoded_objc_compilation_flags - i just recently flipped this 3b67b87, it's in 9.x so should be fine to remove @ HEAD
  • incompatible_disable_native_apple_binary_rule - was a no-op

@dabanki dabanki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 22, 2025
@copybara-service copybara-service bot closed this in cb541be Jan 5, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-ObjC Issues for Objective-C maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants